Skip to content

[artifacts] cspell spelling errors in azure-synapse-artifacts - #26202

Merged
kristapratico merged 5 commits into
Azure:mainfrom
wonder6845:cspellsynapse
Dec 17, 2022
Merged

[artifacts] cspell spelling errors in azure-synapse-artifacts#26202
kristapratico merged 5 commits into
Azure:mainfrom
wonder6845:cspellsynapse

Conversation

@wonder6845

@wonder6845 wonder6845 commented Sep 14, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

closes #22709

In addition, I think 'MetastoreUpdateResponse' should be changed to 'MetastoreUpdateResponse'

@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Sep 14, 2022
@ghost

ghost commented Sep 14, 2022

Copy link
Copy Markdown

Thank you for your contribution wonder6845! We will review the pull request and get back to you soon.

@wonder6845 wonder6845 changed the title [cspell] cspell spelling errors in azure-synapse-artifacts [artifacts] cspell spelling errors in azure-synapse-artifacts Sep 14, 2022
@check-enforcer

check-enforcer Bot commented Sep 14, 2022

Copy link
Copy Markdown

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@kristapratico

kristapratico commented Sep 14, 2022

Copy link
Copy Markdown
Contributor

@wonder6845 thanks for your contribution! I'm not sure I understood this comment:

In addition, I think 'MetastoreUpdateResponse' should be changed to 'MetastoreUpdateResponse'

@xiangyan99

xiangyan99 commented Oct 7, 2022

Copy link
Copy Markdown
Member

/check-enforcer reset

@xiangyan99 xiangyan99 added the needs-author-feedback Workflow: More information is needed from author to address the issue. label Oct 18, 2022
@kristapratico

kristapratico commented Dec 17, 2022

Copy link
Copy Markdown
Contributor

/check-enforcer override

kristapratico
kristapratico approved these changes Dec 17, 2022
View reviewed changes

@kristapratico kristapratico left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wonder6845 I'm going to approve and merge this PR, thanks for the contribution!

regarding:

In addition, I think 'MetastoreUpdateResponse' should be changed to 'MetastoreUpdateResponse'

Please open a new issue if you have any concerns about the library. :)

CI check passes: https://dev.azure.com/azure-sdk/public/_build/results?buildId=2062417&view=results

@kristapratico
kristapratico merged commit 7b243d0 into Azure:main Dec 17, 2022
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Oct 25, 2023
SDKAuto
CodeGen from PR 26202 in Azure/azure-rest-api-specs
bf23f98 
[Hub Generated] Publish private branch 'archidda-azureintegrationspaces-Microsoft.IntegrationSpaces-2023-11-14-preview' (Azure#26202)

* add or modify files

* Address CI errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@kristapratico kristapratico kristapratico approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-author-feedback Workflow: More information is needed from author to address the issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

synapse/azure-synapse-artifacts - cspell found spelling errors in source code

3 participants

@wonder6845 @kristapratico @xiangyan99